ASOC: SOF: mediatek: Add ipc support for mt8195 by kuanhsuncheng · Pull Request #3258 · thesofproject/linux

kuanhsuncheng · 2021-11-04T02:07:11Z

This patch adds IPC support for mt8195 using mbox.

On mt8195 resource, there are two mboxes are used to handle
ipc request and reply.
We create a mtk-adsp-ipc client device to request mbox
controllers.

Signed-off-by: Allen-KH Cheng Allen-KH.Cheng@mediatek.com

Note: there are three patches delivered upstream
https://lore.kernel.org/linux-arm-kernel/20211028132655.8136-1-allen-kh.cheng@mediatek.com/t/

plbossart

I don't fully follow what you are trying to do with a platform device here...

plbossart · 2021-11-04T19:21:13Z

sound/soc/sof/mediatek/mt8195/mt8195.c


+	priv->ipc_dev = platform_device_register_data(&pdev->dev, "mtk-adsp-ipc",
+						      PLATFORM_DEVID_NONE,
+						      pdev, sizeof(*pdev));


where is the platform_device_unregister() done?

Sorry, I miss this part, will fix this. thanks.

plbossart · 2021-11-04T19:22:31Z

sound/soc/sof/mediatek/mt8195/mt8195.c

+		goto err_adsp_sram_power_off;
+	}
+
+	adsp_ipc_set_data(priv->dsp_ipc, priv);


i am not sure I get what you are trying to do here, but the drvdata is typically private stuff handled in the scope of a device. Here you are using it at the parent level. is this intentional and by-design?

YES, this is intentional and by-design. private data is used in mtk adsp IPC IRQ callback func.

imx design uses a separate driver for IPC communication using the mailbox framework (see drivers/mailbox/imx-mailbox.c and drivers/firmware/imx/imx-dsp.c).

We create a child platform device that will be handled by imx-dsp.c mailbox driver. with ipc_set_data call we pass some information from parent to the child.

I'm not sure if MTK has the mailbox driver though because I havent seen one.

Later edit: Oh, now I have seen the link for the mailbox driver in @kuanhsuncheng comment.

@kuanhsuncheng Please Cc me for this kind of patches or at least sound open firmware mailing list. sound-open-firmware@alsa-project.org

yes,

There are three patches are waiting for reviewer reply.

mailbox controller driver
https://patchwork.kernel.org/project/linux-mediatek/patch/20211028132756.8251-1-allen-kh.cheng@mediatek.com/

adsp ipc protocol driver (mailbox client interface)
https://patchwork.kernel.org/project/linux-mediatek/patch/20211028132822.8306-1-allen-kh.cheng@mediatek.com/

This PR should wait upstream finished.

@kuanhsuncheng please mark this PR as draft so that it doesnt get accidentally merged. https://github.blog/changelog/2020-04-08-convert-pull-request-to-draft/

I resend patches again.

(https://lore.kernel.org/linux-arm-kernel/20211117131222.30541-4-allen-kh.cheng@mediatek.com/T/)

Also cc sound-open-firmware@alsa-project.org

Thanks.

kuanhsuncheng

I update the platform_device_unregister part.

For this patch, I refer to imx design.

Note:
Wait upstream done. this patch should not cause compile error
https://lore.kernel.org/linux-arm-kernel/20211028132655.8136-1-allen-kh.cheng@mediatek.com/t/

kuanhsuncheng · 2021-11-05T02:12:50Z

sound/soc/sof/mediatek/mt8195/mt8195.c


+	priv->ipc_dev = platform_device_register_data(&pdev->dev, "mtk-adsp-ipc",
+						      PLATFORM_DEVID_NONE,
+						      pdev, sizeof(*pdev));


Sorry, I miss this part, will fix this. thanks.

kuanhsuncheng · 2021-11-05T02:20:46Z

sound/soc/sof/mediatek/mt8195/mt8195.c

+		goto err_adsp_sram_power_off;
+	}
+
+	adsp_ipc_set_data(priv->dsp_ipc, priv);


YES, this is intentional and by-design. private data is used in mtk adsp IPC IRQ callback func.

cujomalainey · 2021-11-17T19:10:44Z

Did the patch stall getting sent upstream?

kuanhsuncheng · 2021-11-18T01:13:29Z

Did the patch stall getting sent upstream?

I resend the related patches again.

(https://lore.kernel.org/linux-arm-kernel/20211117131222.30541-4-allen-kh.cheng@mediatek.com/T/)

I think this PR should wait upstream finished.

lyakh

feel free to discard my comment after you've addressed it if I'm still on vacation at the time

sound/soc/sof/mediatek/mt8195/mt8195.c

kuanhsuncheng · 2021-12-10T11:58:40Z

Hi sirs,

The below is the upstream list for other related patches.

https://patchwork.kernel.org/project/linux-mediatek/list/?series=593601

I had upstreamed for a while.

Could someone help me review those patches ?

I would appreciate your help. Many thanks.

plbossart · 2021-12-10T14:57:45Z

Could someone help me review those patches ?

@kuanhsuncheng it's a bit confusing since this PR is still a 'draft'. It's not clear if reviewers should spent time on this if you don't update the status?

kuanhsuncheng · 2021-12-13T01:20:08Z

Could someone help me review those patches ?

@kuanhsuncheng it's a bit confusing since this PR is still a 'draft'. It's not clear if reviewers should spent time on this if you don't update the status?

Hi @plbossart ,

This PR is still a draft because I am waiting the below patch list upstream done.

https://patchwork.kernel.org/project/linux-mediatek/list/?series=593601

I wonder maybe there is a way can speed up.

kuanhsuncheng · 2022-01-06T08:34:23Z

@lgirdwood , @dbaluta @plbossart

Hi sirs,

I wonder is that ok I take a another PR for below series.

https://patchwork.kernel.org/project/linux-mediatek/list/?series=605114
https://patchwork.kernel.org/project/linux-mediatek/list/?series=605115

and merge this current PR to sof-dev ?

There are other patches for MT8195 needed to merge also.

However, they have a ipc API dependency and cannot directly merge.

I think maintainer may not have time to rely me. (Upstream series=589151)

please kindly give me advice, thanks.

This patch adds IPC support for mt8195 using mbox. On mt8195 resource, there are two mboxes are used to handle ipc request and reply. We create a mtk-adsp-ipc client device to request mbox controllers. Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>

plbossart · 2022-05-03T22:12:02Z

@kuanhsuncheng is this PR still relevant or can it be closed?

kuanhsuncheng · 2022-05-18T01:55:36Z

Hi sirs,

We can close this PR.

Mark has applied to https://urldefense.com/v3/__https:/git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git__;!!CTRNKA9wMg0ARbw!wU0fgArK_q_tKNK7UqFxsnd2931eAre0YciHrlAxzzQaER8C2tTATfYaiNuALVi85laWXg$ for-next

[2/3] ASoC: SOF: mediatek: Add ipc support for mt8195
commit: aea9350

Thanks,

This patch adds IPC support for mt8195 using mbox. On mt8195 resource, there are two mboxes are used to handle ipc request and reply. We create a mtk-adsp-ipc client device to request mbox controllers. Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> (cherry picked from commit e2a85136b16761f18c181c0483f3d81fe97d7acf https://github.com/kuanhsuncheng/linux.git 8195_dev) PR: thesofproject/linux#3258 BUG=b:189238342 TEST=emerge-cherry sys-kernel/chromeos-kernel-5_10 Signed-off-by: Allen-kh Cheng <allen-kh.cheng@mediatek.corp-partner.google.com> Change-Id: Ie51ff4272eb65940583d1383eea30a036dff50a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3271540 Reviewed-by: Li-Yu Yu <aaronyu@google.com> Commit-Queue: Li-Yu Yu <aaronyu@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3592206 Reviewed-by: YC Hung <yc.hung@mediatek.corp-partner.google.com> Tested-by: Justin Yeh <justin.yeh@mediatek.corp-partner.google.com>

kuanhsuncheng requested review from bardliao, dbaluta, kv2019i, lgirdwood, plbossart and ranj063 as code owners November 4, 2021 02:07

kuanhsuncheng force-pushed the 8195_dev branch from 435f068 to 331a22d Compare November 4, 2021 02:11

kuanhsuncheng requested a review from yaochunhung November 4, 2021 02:12

plbossart reviewed Nov 4, 2021

View reviewed changes

kuanhsuncheng force-pushed the 8195_dev branch from 331a22d to e2a8513 Compare November 5, 2021 02:07

kuanhsuncheng commented Nov 5, 2021

View reviewed changes

kuanhsuncheng marked this pull request as draft November 5, 2021 08:06

lyakh requested changes Nov 26, 2021

View reviewed changes

sound/soc/sof/mediatek/mt8195/mt8195.c Outdated Show resolved Hide resolved

kuanhsuncheng force-pushed the 8195_dev branch from e2a8513 to 551beed Compare December 10, 2021 11:52

kuanhsuncheng force-pushed the 8195_dev branch from 551beed to b90d3fc Compare December 16, 2021 05:20

yaochunhung mentioned this pull request Jan 11, 2022

ASoC: SOF: ipc: introduce cont_update_posn in sof_ipc_stream_params s… #3353

Merged

kuanhsuncheng force-pushed the 8195_dev branch from b90d3fc to 774869b Compare January 13, 2022 12:50

kuanhsuncheng closed this May 18, 2022

Conversation

kuanhsuncheng commented Nov 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

plbossart left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dbaluta Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kuanhsuncheng Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kuanhsuncheng left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cujomalainey commented Nov 17, 2021

Uh oh!

kuanhsuncheng commented Nov 18, 2021

Uh oh!

lyakh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kuanhsuncheng commented Dec 10, 2021

Uh oh!

plbossart commented Dec 10, 2021

Uh oh!

kuanhsuncheng commented Dec 13, 2021

Uh oh!

kuanhsuncheng commented Jan 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

plbossart commented May 3, 2022

Uh oh!

kuanhsuncheng commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kuanhsuncheng commented Nov 4, 2021 •

edited

Loading

dbaluta Nov 5, 2021 •

edited

Loading

kuanhsuncheng Nov 5, 2021 •

edited

Loading

kuanhsuncheng commented Jan 6, 2022 •

edited

Loading

kuanhsuncheng commented May 18, 2022 •

edited

Loading